Preheat oven to 350°F. Line a 24-cup muffin pan with paper liners or grease lightly.
In a large bowl, beat butter and sugar on medium-high speed until light and fluffy, about 3-4 minutes. The mixture should look pale and creamy.
Add eggs one at a time, beating well after each addition. Mix in vanilla and rosewater.
In a separate bowl, whisk together flour, baking powder, and salt.
Alternate adding the dry ingredients and milk to the butter mixture, beginning and ending with flour mixture. Beat on low just until combined—do not overmix.
Divide batter evenly among cups (about 2 tablespoons each). Bake for 18-20 minutes or until a toothpick inserted in the center comes out clean. Let cool completely before frosting.
For the buttercream: beat softened butter on medium-high speed until smooth and creamy, about 3 minutes. Add confectioners' sugar gradually, then heavy cream, vanilla, rosewater, and salt. Beat on high for 4-5 minutes until light and fluffy. Add a few drops of food coloring gel if desired.
Frost cooled cupcakes generously with the buttercream. Store in an airtight container at room temperature for up to 3 days or in the refrigerator for up to a week. Bring to room temperature before serving.